perf(test_utils): replace sleep with async queue join when stopping test stream #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeroennC
commented
Nov 15, 2022
JeroennC
commented
Nov 15, 2022
…est stream TestStreamClient uses async queues in the background, which can be awaited for all processing to be done. This speeds up tests starting and stopping the TestStreamClient by removing the 1s sleep.
c4b968f to
95babab
Compare
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 95.53% 95.93% +0.40%
==========================================
Files 16 16
Lines 381 394 +13
==========================================
+ Hits 364 378 +14
+ Misses 17 16 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
marcosschroh
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestStreamClient uses async queues in the background, which can be awaited for all processing to be done. This speeds up tests starting and stopping the TestStreamClient by removing the 1s sleep.
An assumption is made to call
task_donein the TestConsumer.getone, as there is no callback towards the consumer after processing a record. I believe the existing test cases should still be sufficient, please let me know if you see some edge cases where this would not work or needs extra testing.