Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Singlenton removed from PrometheusMonitor #105

Merged

Conversation

marcosschroh
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #105 (6b6fcaa) into master (0212c86) will increase coverage by 0.40%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   95.56%   95.97%   +0.40%     
==========================================
  Files          21       20       -1     
  Lines         677      670       -7     
==========================================
- Hits          647      643       -4     
+ Misses         30       27       -3     
Flag Coverage Δ
unittests 95.97% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kstreams/test_utils/test_utils.py 97.82% <ø> (-0.05%) ⬇️
kstreams/engine.py 97.95% <100.00%> (ø)
kstreams/prometheus/monitor.py 100.00% <100.00%> (+4.54%) ⬆️
kstreams/rebalance_listener.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Damephena Damephena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosschroh marcosschroh merged commit 629f1ff into kpn:master Mar 6, 2023
@marcosschroh marcosschroh deleted the fix/remove-prometheus-singlenton branch March 6, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants