Consolidate RCS support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "fs" backend was filtered out of the list of valid values for the `--storage` option on these commands. The only remaining option would be "gitfs", so there is no need for an option.
If a store does not exist, then it should be initialized with the `init` command. The purpose of the `rcs init` command is to initialize a Git repository in an existing "fs" store that has no revision control, so we won't get the desired result if we fail the init, or if we just do nothing, when the store is using the "fs" backend. It also makes no sense to check the backend for the context because that is initialized from the root store only, and the actual storage could be different if the "--store" option was used.
Now that Git is the only RCS provider, `gopass git` is the only extra command introduced by the storage backends. We can eliminate the extra complexity of the extension commands interface by moving it to the regular commands array, and there's even a leftover `Git` command func that we can reuse.
- `rcs status` duplicates the functionality of `git status`. - `RCSRemoveRemote` is never used. - `RCSPull`, `RCSPush`, and `RCSAddRemote` are used as store functions from other actions, but the action functions are unused.
The "init" subcommand was the only subcommand left under the old "rcs" command. Since it runs a `git init` command, but with important additional configuration, we can make it a subcommand of "gopass git" so that it will be used instead of just forwarding the "init" command directly to `git`. This allows the "git" command to completely replace the "rcs" command.
The `Storage` interface embeds the `rcs` interface. This increases the total method count in the interface, but doesn't actually affect the number of methods that must be implemented compared to treating `rcs` and `Storage` as independent interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for Fossil revision control, and focus only on Git. Consolidate revision control commands under
gopass gitand removegopass rcs.