Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test GHC 9.12; support base < 4.22, ghc-prim < 0.14 #462

Merged
merged 4 commits into from
Mar 9, 2025
Merged

Test GHC 9.12; support base < 4.22, ghc-prim < 0.14 #462

merged 4 commits into from
Mar 9, 2025

Conversation

tomjaguarpaw
Copy link
Contributor

No description provided.

@tomjaguarpaw tomjaguarpaw force-pushed the 9.12 branch 2 times, most recently from 1eda416 to f49a81a Compare December 23, 2024 16:00
@tomjaguarpaw
Copy link
Contributor Author

Will have to leave this until doctest gets brought up-to-date.

@Bodigrim
Copy link
Collaborator

Bodigrim commented Mar 1, 2025 •
edited
Loading

Will have to leave this until doctest gets brought up-to-date.

You need to relax doctest >= 0.20 && < 0.23 to allow doctest-0.24.

@tomjaguarpaw
Copy link
Contributor Author

Now stuck on a doctest error, because the formatting of exceptions has changed.

If a Relude user wants to submit a patch in the next few days to fix this I'll take it, otherwise I think I'll just drop this particular doctest.

src/Relude/Debug.hs:268: failure in expression `error "oops"'
expected: *** Exception: oops
          CallStack (from HasCallStack):
            error, called at src/Relude/Debug.hs:296:11 in ...
          ...
 but got: *** Exception: oops
          
          ^
          HasCallStack backtrace:
            error, called at src/Relude/Debug.hs:296:11 in main:Relude.Debug
            error, called at <interactive>:1442:1 in interactive:Ghci6

@tomjaguarpaw
Test GHC 9.12; support base < 4.22, ghc-prim < 0.14, doctest < 0.25
ca25212 
We have to drop testing 8.4 because tasty tasty-1.5.3 doesn't build on
8.4 but doesn't have a lower bound that excludes it.

Drop a doctest which changes in 9.12. I don't know how to bring it up
to date in way that will allow it to pass CI for all versions of GHC
at once.
@tomjaguarpaw tomjaguarpaw merged commit 4780d0e into main Mar 9, 2025
15 checks passed
@tomjaguarpaw tomjaguarpaw deleted the 9.12 branch March 9, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 Awaiting requested review from vrom911 vrom911 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomjaguarpaw @Bodigrim