Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#157] Show issues from the current milestone #169

Merged
merged 3 commits into from
Jun 25, 2020
Merged

[#157] Show issues from the current milestone #169

merged 3 commits into from
Jun 25, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Jun 25, 2020

Resolves #157

@vrom911 vrom911 added GitHub GitHub API Git Git commands CLI command-line interface labels Jun 25, 2020
@vrom911 vrom911 requested a review from chshersh as a code owner June 25, 2020 17:21
@vrom911 vrom911 self-assigned this Jun 25, 2020
hint-man[bot]
hint-man bot approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

chshersh
chshersh approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is very nice! And the code became much cleaner 👍

src/Hit/Issue.hs Outdated
fetchCurrentMilestoneId = withOwnerRepo milestones' >>= \case
Left err -> warningMessage (show err) >> pure Nothing
Right ms -> case sortBy (flip compare) $ map (untagId . milestoneNumber) $ toList ms of
[] -> warningMessage "" >> pure Nothing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we print something here like No milestones created?

src/Hit/Issue.hs Outdated Show resolved Hide resolved
vrom911 and others added 2 commits June 25, 2020 18:34
@vrom911 @chshersh
Update src/Hit/Issue.hs
9780623 
Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>
@vrom911
Add more useful warning messages
965f639
@chshersh chshersh merged commit d6f6559 into master Jun 25, 2020
@chshersh chshersh deleted the vrom911/157-Show-issues-from-the-current branch June 25, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] approved these changes

@chshersh chshersh chshersh approved these changes

Assignees

@vrom911 vrom911

Labels
CLI command-line interface Git Git commands GitHub GitHub API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Show issues from the current milestone
2 participants
@vrom911 @chshersh