actions: tests for platform-specific install scripts #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might end up being a noisy check given its current triggers, but I can clean it up a bit to run less on most changes. |
|
wild, does the stay running on the GitHub action server? |
|
should probably have this be manually triggered (or triggered if files in docker folders change), since I infrequently change the install scripts. edit: never mind, I see you did that! |
Github actions will spin up VMs for each job so I believe once the job completes they are deleted. The job has a max lifetime of 6 hours before it's killed, so we can add and run more tests on the scrypted server as part of the actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm open to discussing whether or not something like this would be useful to have in general, but I figured it could be helpful to kick off a set of tests to verify scrypted installs on different platforms.
Right now this only tests the installation, but I intend to add more functional testing, including installing plugins that need system dependencies.