Battery cams api fixes #1719
Merged
Battery cams api fixes #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koush
reviewed
Feb 1, 2025
koush
reviewed
Feb 1, 2025
| } | ||
| catch (e) { | ||
| this.console.log('Error in getting battery info', e); | ||
| } | ||
| }, 1000 * 60 * 30); | ||
| }, 1000 * 10); |
There was a problem hiding this comment.
doesn't making this request keep the battery camera awake?
There was a problem hiding this comment.
No this won't wake it up, this will be handled by the hub and battery cams only work with hub on scrypted
What value would you suggest?
There was a problem hiding this comment.
I think preserving existing interval for non battery cams is preferable.
There was a problem hiding this comment.
The interval won't start for non battery cams at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves handling of online state on Reolink battery camses, increasing the checking on the online state and allow the snapshot plugin to get more relevant snapshots
Fix for battery camera motion reporting, it comes as an event instead of Ai result