diagnostics: gpu decode test

koush · Sep 11, 2024 · 341cfa1 · 341cfa1
1 parent 9633554
commit 341cfa1
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 16 deletions.
diff --git a/plugins/diagnostics/package-lock.json b/plugins/diagnostics/package-lock.json
diff --git a/plugins/diagnostics/package.json b/plugins/diagnostics/package.json
@@ -1,6 +1,6 @@
 {
    "name": "@scrypted/diagnostics",
-   "version": "0.0.6",
+   "version": "0.0.8",
    "scripts": {
       "scrypted-setup-project": "scrypted-setup-project",
       "prescrypted-setup-project": "scrypted-package-json",
@@ -20,7 +20,7 @@
       "diagnostics"
    ],
    "scrypted": {
-      "name": "Scrypted Diagnostics Plugin",
+      "name": "Scrypted Diagnostics",
       "type": "API",
       "interfaces": [
          "Settings"

diff --git a/plugins/diagnostics/src/main.ts b/plugins/diagnostics/src/main.ts
@@ -1,16 +1,19 @@
+import child_process from 'child_process';
 import sharp from 'sharp';
 import net from 'net';
 import fs from 'fs';
 import os from 'os';
 import sdk, { Camera, MediaObject, MediaStreamDestination, MotionSensor, Notifier, OnOff, ScryptedDevice, ScryptedDeviceBase, ScryptedDeviceType, ScryptedInterface, Setting, Settings, VideoCamera } from '@scrypted/sdk';
 import { StorageSettings } from '@scrypted/sdk/storage-settings';
 import { httpFetch, httpFetchParseIncomingMessage } from '../../../server/src/fetch/http-fetch';
-
+import { safeKillFFmpeg } from '@scrypted/common/src/media-helpers';
+import { Deferred } from '@scrypted/common/src/deferred';
 class DiagnosticsPlugin extends ScryptedDeviceBase implements Settings {
     storageSettings = new StorageSettings(this, {
         testDevice: {
             group: 'Device',
-            title: 'Test Device',
+            title: 'Validation Device',
+            description: "Select a device to validate.",
             type: 'device',
             deviceFilter: `type === '${ScryptedDeviceType.Camera}' || type === '${ScryptedDeviceType.Doorbell}'  || type === '${ScryptedDeviceType.Notifier}'`,
             immediate: true,
@@ -140,17 +143,28 @@ class DiagnosticsPlugin extends ScryptedDeviceBase implements Settings {
                 throw new Error('Doorbell button not found.');
         });
 
-        await this.validate('Recent Motion', async () => {
+        await this.validate('Motion Detection', async () => {
             if (!device.interfaces.includes(ScryptedInterface.MotionSensor))
                 throw new Error('Motion Sensor not found. Enabling a software motion sensor extension is recommended.');
 
-            const lastMotion = this.loggedMotion.get(device.id);
-            if (!lastMotion)
-                throw new Error('No recent motion detected. Go wave your hand in front of the camera.');
-            if (Date.now() - lastMotion > 8 * 60 * 60 * 1000)
-                throw new Error('Last motion was over 8 hours ago.');
+            if (device.providedInterfaces.includes(ScryptedInterface.MotionSensor)) {
+                if (device.interfaces.find(i => i.startsWith('ObjectDetection:true')))
+                    this.warnStep('Camera hardware provides motion events, but a software motion detector is enabked. Consider disabling the software motion detector.');
+            }
         });
 
+        if (device.interfaces.includes(ScryptedInterface.MotionSensor)) {
+            await this.validate('Recent Motion', async () => {
+
+                const lastMotion = this.loggedMotion.get(device.id);
+                if (!lastMotion)
+                    throw new Error('No recent motion detected. Go wave your hand in front of the camera.');
+                if (Date.now() - lastMotion > 8 * 60 * 60 * 1000)
+                    throw new Error('Last motion was over 8 hours ago.');
+            });
+        }
+
+
         if (device.type === ScryptedDeviceType.Doorbell) {
             await this.validate('Recent Button Press', async () => {
                 const lastButton = this.loggedButton.get(device.id);
@@ -362,6 +376,38 @@ class DiagnosticsPlugin extends ScryptedDeviceBase implements Settings {
             });
         }
 
+        if (nvrPlugin) {
+            await this.validate("GPU Decode", async () => {
+                const ffmpegPath = await sdk.mediaManager.getFFmpegPath();
+                const args = [
+                    '-y',
+                    '-hwaccel', 'auto',
+                    '-i', 'https://github.com/koush/scrypted-sample-cameraprovider/raw/main/fs/dog.mp4',
+                    '-f', 'rawvideo',
+                    'pipe:3',
+                ];
+                const cp = child_process.spawn(ffmpegPath, args, {
+                    stdio: ['pipe', 'pipe', 'pipe', 'pipe'],
+                });
+
+                const deferred = new Deferred<void>();
+                deferred.promise.catch(() => { }).finally(() => safeKillFFmpeg(cp));
+                cp.stdio[3]?.on('data', () => { });
+
+                cp.stderr!.on('data', data => {
+                    const str = data.toString();
+                    if (str.includes('nv12'))
+                        deferred.resolve();
+                });
+
+                setTimeout(() => {
+                    deferred.reject(new Error('GPU Decode failed.'));
+                }, 5000);
+
+                await deferred.promise;
+            });
+        }
+
         this.console.log(''.padEnd(80, '='));
         this.console.log('System Validation Complete');
         this.console.log(''.padEnd(80, '='));

diff --git a/server/src/media-helpers.ts b/server/src/media-helpers.ts
@@ -17,8 +17,8 @@ export async function safeKillFFmpeg(cp: ChildProcess) {
         cp.on('exit', resolve);
         // this will allow ffmpeg to send rtsp TEARDOWN etc
         try {
-            cp.stdin.on('error', () => { });
-            cp.stdin.write('q\n');
+            cp.stdin!.on('error', () => { });
+            cp.stdin!.write('q\n');
         }
         catch (e) {
         }
@@ -55,8 +55,8 @@ export function ffmpegLogInitialOutput(console: Console, cp: ChildProcess, forev
             if (!SCRYPTED_FFMPEG_NOISY && !forever && (str.indexOf('frame=') !== -1 || str.indexOf('size=') !== -1)) {
                 log(str);
                 log('video/audio detected, discarding further input');
-                cp.stdout.removeListener('data', ret);
-                cp.stderr.removeListener('data', ret);
+                cp.stdout!.removeListener('data', ret);
+                cp.stderr!.removeListener('data', ret);
                 return;
             }