Make custom text replaces work without replace emoji being enabled

[the-blank-x]

Depends on kotatogram/lib_ui#11

[ilya-fedin]

That would make people who don't like text replaces angry I guess :D

[the-blank-x]

Then don't have any text replaces lol

[ilya-fedin]

I don't think you really need to change lib_ui's API. It would make more sense to replace the array used in setInstantReplaces when the option changes than creating a new weird special-case API.

[ilya-fedin]

Then don't have any text replaces lol

I don't quite understand what you wanted to say

[the-blank-x]

I don't think you really need to change lib_ui's API. It would make more sense to replace the array used in setInstantReplaces when the option changes than creating a new weird special-case API.

When you change the replace emoji option it applies instantly without having to reopen kotatogram

[ilya-fedin]

When you change the replace emoji option it applies instantly without having to reopen kotatogram

The call to setInstantReplaces should have effect instantly as well

[the-blank-x]

The call to setInstantReplaces should have effect instantly as well

I don't get what you're saying

[ilya-fedin]

Example of what I mean:

	Core::App().settings().replaceEmojiValue(
	) | rpl::start_with_next([=](bool replaceEmoji) {
		if (replaceEmoji) {
			text->setInstantReplaces(Ui::InstantReplaces::Default());
		} else {
			text->setInstantReplaces(Kotato::InstantReplaces::TextOnly());
		}
	});

[ilya-fedin]

But I still don't think having text-only replaces always is a good idea, I'm pretty sure that would make people angry

[the-blank-x]

I want https://github.com/kotatogram/kotatogram-desktop/wiki/Custom-text-replaces to work even if Replace emoji is disabled, if you don't want them you can always remove it from the config

[ilya-fedin]

I want https://github.com/kotatogram/kotatogram-desktop/wiki/Custom-text-replaces to work even if Replace emoji is disabled

Ah. I thought you want these replaces: https://github.com/kotatogram/lib_ui/blob/master/ui/widgets/input_fields.cpp#L917-L924

It seems to me that the proper way would be to have a setInstantReplaces that accepts a rpl::producer then. That would allow the set to be changed at any time in runtime.

[EricKotato]

I will return to it after next stable release.