Bugfix: BindingListCollectionView item replace issue (dotnet#1314)

koszeggy · Apr 23, 2020 · 7b6a725 · 7b6a725
1 parent f226a72
commit 7b6a725
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/...oft.DotNet.Wpf/src/PresentationFramework/System/Windows/Data/BindingListCollectionView.cs b/...oft.DotNet.Wpf/src/PresentationFramework/System/Windows/Data/BindingListCollectionView.cs
@@ -2009,6 +2009,18 @@ private void OnListChanged(object sender, ListChangedEventArgs args)
                 break;
 
             case ListChangedType.ItemChanged:
+                // if there is no PropertyDescriptor, then ItemChanged refers to a Replace event
+                // (IBindingList indexer set) and not a property change of an item
+                if (args.PropertyDescriptor == null)
+                {
+                    item = InternalList[index];
+                    var oldItem = _cachedList[index];
+                    _cachedList[index] = item;
+                    forwardedArgs = new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Replace, item, oldItem, index);
+                    break;
+                }
+
+                // here ItemChange refers to a property change
                 if (!_itemsRaisePropertyChanged.HasValue)
                 {
                     // check whether individual items raise PropertyChanged events