Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all cache backends of Django >=3.2 #329

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Conversation

tneuct
Copy link
Contributor

@tneuct tneuct commented May 23, 2022

When upgrading to Django 3.2, the django-prometheus package caused some issues because it forces the user to use the PyLibMCCache without making the implicit requirement of pylibmc transparent to the user or directly requiring the package (introduced by #296). Additionally, the deprecation warning is hidden from the user.

Django 3.2 gives the user the option to keep on using the deprecated backend, and also adds another cache backend than the pylibmc-based one.

This merge request adds support for all cache backends of Django 3.2 and lets the user choose between them according to the official Django documentation.

This closes issue #328

@asherf
Copy link
Collaborator

asherf commented Jul 14, 2022

thanks. sorry for not reviewing sooner.
I'll try to land this in a release in the next week or so.

@asherf asherf merged commit 57a7ad7 into korfuri:master Jul 14, 2022
@mounirmesselmeni
Copy link

mounirmesselmeni commented Sep 29, 2022

Any plan for a release soon? I also need this but it's not in the current pypi release.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants