Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fail_if_updated and fail_if_unknown #144

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

tisonkun
Copy link
Member

No description provided.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun enabled auto-merge (squash) April 23, 2024 11:40
@tisonkun
Copy link
Member Author

tisonkun commented Apr 23, 2024

@YuanYuYuan You may try out this patch with:

      - uses: korandoru/hawkeye@main
        with:
          mode: format
          args: --fail-if-updated=false

After it gets merged. Or tisonkun/hawkeye@add-fail-if-updated if before it merged.

@tisonkun
Copy link
Member Author

In this way, we can keep the compatibility and release a v5.5.0 instead.

@tisonkun tisonkun merged commit 37db603 into korandoru:main Apr 23, 2024
15 checks passed
@YuanYuYuan
Copy link
Contributor

@YuanYuYuan You may try out this patch with:

      - uses: korandoru/hawkeye@main
        with:
          mode: format
          args: --fail-if-updated=false

After it gets merged. Or tisonkun/hawkeye@add-fail-if-updated if before it merged.

Thanks! I think adding this argument is better and more general. 👍

@tisonkun tisonkun deleted the add-fail-if-updated branch April 23, 2024 15:19
@tisonkun
Copy link
Member Author

@YuanYuYuan OK. I'll release a v5.5.0 tomorrow. And alias it as v5.

@tisonkun
Copy link
Member Author

@YuanYuYuan Released.

@YuanYuYuan
Copy link
Contributor

@YuanYuYuan Released.

That's great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants