refactor(logging): replace error! by info! in the actions of format and remove

[YuanYuYuan]

Hi there! I found that a log containing errors can stop the Github action. However, the actions format and remove should not be treated as errors since they're intended by the users.

[tisonkun]

We exit with non-zero code, so IMO use error doesn't hurt.

If we think of it's intended by users, info is more proper.

[YuanYuYuan]

We exit with non-zero code, so IMO use error doesn't hurt.

If we think of it's intended by users, info is more proper.

Hi @tisonkun! This is the failed log we encountered. I also have no idea why it failed directly. Regarding the logging level, I agree with your point. I'll make the change.

[tisonkun]

@YuanYuYuan The workflow fails because we exit with -1, unrelated to these logs.

You can run the commit change step with if: failure() condition, see: https://docs.github.com/en/actions/learn-github-actions/expressions#failure.

It also helps to ensure that you only commit if any file gets changed.

[tisonkun]

I tend to keep the current code as is then.

[YuanYuYuan]

@YuanYuYuan The workflow fails because we exit with -1, unrelated to these logs.

You can run the commit change step with if: failure() condition, see: https://docs.github.com/en/actions/learn-github-actions/expressions#failure.

It also helps to ensure that you only commit if any file gets changed.

Yes. Similarly, we used continue_on_error to workaround it. But I'm wondering if this is a good design. Let me explain the reasons.

1. I didn't expect to receive errors when running hawkeye format to format the files we want to change. And the unknown files are complained with warn instead. Referring to one of the popular tools, SkyWalking Eyes use INFO to inform the users.
2. An auto fix integrated with the Github action is quite appealing. Just like the example in SkyWalking Eyes. As hawkeye format has already been able to return 1 to indicate any missing headers, do you think it's good to change the return code in hawkeye format and hawkeye remove so that users no longer need to use the above tricks?

[tisonkun]

@YuanYuYuan Make sense. Let me update the exit code part and release a v6.0.

I'll ping you as a reviewer when a patch is ready.

[YuanYuYuan]

@YuanYuYuan Make sense. Let me update the exit code part and release a v6.0.

I'll ping you as a reviewer when a patch is ready.

Many thanks! 😃