Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix reservation reserved updated #2322

Conversation

saintube
Copy link
Member

@saintube saintube commented Jan 17, 2025

Ⅰ. Describe what this PR does

koord-scheduler: fix a bug where the reserved in a Reservation does not refresh for the Update event.

Ⅱ. Does this pull request fix one issue?

related to #2315.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com>
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the scheduler-fix-reservation-reserved branch from c636841 to 3b18165 Compare January 17, 2025 05:54
@ZiMengSheng
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.98%. Comparing base (79036cf) to head (3b18165).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2322      +/-   ##
==========================================
- Coverage   66.09%   65.98%   -0.11%     
==========================================
  Files         458      458              
  Lines       54200    54205       +5     
==========================================
- Hits        35823    35769      -54     
- Misses      15803    15871      +68     
+ Partials     2574     2565       -9     
Flag Coverage Δ
unittests 65.98% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot koordinator-bot bot merged commit d679e49 into koordinator-sh:main Jan 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants