Create Rules for SimpleEvaluationContext

default/generated/spring-framework/spring-framework-5.x-to-6.0-core-container.yaml

@@ -41,3 +41,29 @@
     - title: 'Spring 6.0 migration guide'
       url: https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-6.0-Release-Notes#core-container
 
+- ruleID: spring-framework-5.x-to-6.0-core-container-00020
+  category: potential
+  effort: 1
+  labels:
+  - konveyor.io/source=spring5
+  - konveyor.io/target=spring6+
+  when:
+    or:
+    - java.referenced:
+        location: FIELD
+        pattern: org.springframework.expression.spel.support.SimpleEvaluationContext
+    - java.referenced:
+        location: CONSTRUCTOR_CALL
+        pattern: org.springframework.expression.spel.support.SimpleEvaluationContext
+  description: Replace SimpleEvaluationContext with StandardEvaluationContext when working with array operations.
+  message: |
+    `SimpleEvaluationContext` now disallows creating arrays inside expressions which aligns with how regular constructor resolution works.
+
+    Code that relies on creating arrays within expressions using `SimpleEvaluationContext` might malfunction or produce unexpected results.
+
+    It is recommended to switch to `org.springframework.expression.spel.standard.StandardEvaluationContext` as it offers the full SpEL functionality, 
+    including array creation within expressions as well as improved performance.
+  links:
+  - title: 'Spring 6.0 migration guide'
+    url: https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-6.0-Release-Notes#core-container
+

default/generated/spring-framework/tests/data/core-container/src/main/java/org/konveyor/spel/DynamicQueryService.java

@@ -0,0 +1,23 @@
+package java.org.konveyor.spel;
+
+import org.springframework.expression.Expression;
+import org.springframework.expression.ExpressionParser;
+import org.springframework.expression.spel.standard.SpelExpressionParser;
+import org.springframework.expression.spel.support.SimpleEvaluationContext;
+import org.springframework.stereotype.Service;
+
+import java.util.List;
+
+@Service
+public class DynamicQueryService {
+
+    public String generateSql(List<Integer> ids) {
+        ExpressionParser parser = new SpelExpressionParser();
+        SimpleEvaluationContext context = new SimpleEvaluationContext();
+
+        context.setRootObject(ids);
+        Expression expression = parser.parseExpression("'IN (' + #root.join(\',\') + ')'");
+        String inClause = (String) expression.getValue(context);
+        return "SELECT * FROM users WHERE user_id " + inClause;
+    }
+}

default/generated/spring-framework/tests/data/core-container/src/main/java/org/konveyor/spel/SecondaryQueryService.java

@@ -0,0 +1,27 @@
+package java.org.konveyor.spel;
+
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.expression.Expression;
+import org.springframework.expression.ExpressionParser;
+import org.springframework.expression.spel.standard.SpelExpressionParser;
+import org.springframework.expression.spel.support.*;
+import org.springframework.stereotype.Service;
+
+import java.util.List;
+
+
+@Service
+public class SecondaryQueryService {
+
+    @Autowired
+    private SimpleEvaluationContext evaluationContext;
+
+    public String generateSql(List<Integer> ids) {
+        ExpressionParser parser = new SpelExpressionParser();
+
+        evaluationContext.setRootObject(ids);
+        Expression expression = parser.parseExpression("'IN (' + #root.join(\',\') + ')'");
+        String inClause = (String) expression.getValue(evaluationContext);
+        return "SELECT * FROM users WHERE user_id " + inClause;
+    }
+}

default/generated/spring-framework/tests/spring-framework-5.x-to-6.0-core-container.test.yaml

@@ -17,3 +17,10 @@ tests:
         mode: "source-only"
       hasIncidents:
         exactly: 2
+- ruleID: spring-framework-5.x-to-6.0-core-container-00020
+  testCases:
+    - name: tc-2
+      analysisParams:
+        mode: "source-only"
+      hasIncidents:
+        exactly: 2