test: added test for mergeProcessFileCallBack function #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
|
Thanks for making a pull request! 😃 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
==========================================
+ Coverage 14.76% 14.82% +0.05%
==========================================
Files 90 90
Lines 8379 8379
==========================================
+ Hits 1237 1242 +5
+ Misses 6824 6818 -6
- Partials 318 319 +1 ☔ View full report in Codecov by Sentry. |
kmehant
approved these changes
Dec 14, 2023
seshapad
reviewed
Dec 14, 2023
filesystem/merger_test.go
Outdated
| func TestMergeProcessFileCallBack_SameContent(t *testing.T) { | ||
| t.Run("test for source and destination files with same content", func(t *testing.T) { | ||
|
|
||
| sourceFile, err := ioutil.TempFile("", "source") |
There was a problem hiding this comment.
Can you use a variable (named appropriately) to represent the empty string
Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
seshapad
reviewed
Dec 14, 2023
filesystem/merger_test.go
Outdated
| } | ||
| defer os.Remove(sourceFile.Name()) | ||
|
|
||
| destinationFile, err := ioutil.TempFile("", "destination") |
There was a problem hiding this comment.
Use nonExistentPath here as well.
Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
seshapad
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test for mergeProcessFileCallBack function
i) this test covers a scenario when the source and destination files are of same content.
fixes a part of #881