-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for mergeDeletionCallBack #1118
Conversation
Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
Thanks for making a pull request! 😃 |
@satyazzz123 License is missing from the file. Please add it and address the lint issues. Please check for lint issues by running |
Signed-off-by: satyazzz123 <beherasatyajit716@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
+ Coverage 14.81% 14.86% +0.04%
==========================================
Files 90 90
Lines 8321 8321
==========================================
+ Hits 1233 1237 +4
+ Misses 6770 6766 -4
Partials 318 318 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @satyazzz123 for the contribution, please feel free to add more test cases to this test function and also cover other functions in this file.
cc @seshapad
Yess I am working on the other tests soon will raise another PR. |
tests for mergeDeletionCallback
i) This test case covers a scenario when function is called with a non-existent source file and an existing destination directory
fixes a part of #881