fix: respect DOCKER_HOST env var for better container runtime Support #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request! 😃 |
DOCKER_HOST is now respected so the binary could be run again other runtimes like podman, that exposes a compatible socket based api. To use it export DOCKER_HOST=unix:///run/user/1000/podman/podman.sock for running with a non root user. If DOCKER_HOST is not exported then the default path /var/run/docker.socket Signed-off-by: Roy Golan <rgolan@redhat.com>
69d6334 to
2e6476b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOCKER_HOST is now respected so the binary could be run again other
runtimes like podman, that exposes a compatible socket based api.
To use it export DOCKER_HOST=unix:///run/user/1000/podman/podman.sock
for running with a non root user.
If DOCKER_HOST is not exported then the default path
/var/run/docker.socket
Signed-off-by: Roy Golan rgolan@redhat.com