added bubbletea quit method instead of os exit #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I'll test it. A quick note on the PR:
|
|
LGTM |
1 task
fharper
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
You tested it, @CristhianF7 also, and I, and it fixed the issue so from my POV, we're good to merge this. If the reporter for the initial issue see any problems we can revisit, but as far as I'm concerned, this issue is fixed, thanks you both, it was such an annoying bug, worth releasing if you ask me :)
Closed
CristhianF7
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in stty there is echo option which is set off when bubbletea is working,so if we do bubbletea.Quit() it sets it to on and then quits