No EMA buffer at beta1==0 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstmish
reviewed
Dec 17, 2024
prodigyopt/prodigy.py
Outdated
| exp_avg = state['exp_avg'] | ||
| p.data.addcdiv_(exp_avg,denom, value=-dlr) | ||
| else: | ||
| p.data.addcdiv_(grad,denom, value=-dlr * d) |
There was a problem hiding this comment.
Could you please fix the formatting? (missing spaces after ,)
There was a problem hiding this comment.
I'm an a business trip - I have checked the "Allow edits by maintainers" checkbox - not sure how this works exactly, but I suppose there is an easy way for you to directly make this change on the github website, no?
There was a problem hiding this comment.
Yeah that setting makes it possible for repo admins to edit PR code via GitHub.
There was a problem hiding this comment.
Indeed, I could do it myself, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25 (comment)