Add major/minor/micro for Version #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischaojie
commented
May 5, 2023
src/version.rs
Outdated
Comment on lines
354
to
367
| #[getter] | ||
| pub fn major(&self) -> usize { | ||
| self.0.major | ||
| } | ||
| /// The second item of release or 0 if unavailable. | ||
| #[getter] | ||
| pub fn minor(&self) -> usize { | ||
| self.0.minor | ||
| } | ||
| /// The third item of release or 0 if unavailable. | ||
| #[getter] | ||
| pub fn micro(&self) -> usize { | ||
| self.0.micro | ||
| } |
There was a problem hiding this comment.
yeah, but don't make them fields of the object (they are duplicate with the release vec), but get them dynamically from the vec
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
packaging: https://packaging.pypa.io/en/stable/version.html#packaging.version.Version.major, addmajor/minor/microproperty.