-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RHTAPWATCH-782): Add product version controller ADR #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifireball
force-pushed
the
pvc-adr
branch
2 times, most recently
from
February 5, 2024 12:39
ce952bb
to
864d0b8
Compare
scoheb
reviewed
Feb 5, 2024
scoheb
reviewed
Feb 5, 2024
ralphbean
reviewed
Feb 5, 2024
ralphbean
reviewed
Feb 5, 2024
ralphbean
reviewed
Feb 5, 2024
ralphbean
reviewed
Feb 5, 2024
ralphbean
reviewed
Feb 5, 2024
Roming22
reviewed
Feb 5, 2024
arewm
reviewed
Feb 6, 2024
ralphbean
reviewed
Feb 12, 2024
ralphbean
reviewed
Feb 16, 2024
ralphbean
reviewed
Feb 16, 2024
twaugh
reviewed
Feb 20, 2024
twaugh
reviewed
Feb 20, 2024
twaugh
reviewed
Mar 5, 2024
Signed-off-by: Barak Korren <bkorren@redhat.com>
Signed-off-by: Barak Korren <bkorren@redhat.com>
Signed-off-by: Barak Korren <bkorren@redhat.com>
Signed-off-by: Barak Korren <bkorren@redhat.com>
Also renamed the file to better reflect the controller name. Signed-off-by: Barak Korren <bkorren@redhat.com>
ifireball
changed the title
Add product version controller ADR
feat(RHTAPWATCH-782): Add product version controller ADR
Apr 1, 2024
@ralphbean what is the gap to getting this merged? |
Signed-off-by: Barak Korren <bkorren@redhat.com>
LGTM! |
scoheb
approved these changes
May 9, 2024
arewm
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an ADR describing how to add product and version support to Konflux via a new controller