Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHTAPWATCH-782): Add product version controller ADR #166

Merged
merged 7 commits into from
May 9, 2024

Conversation

ifireball
Copy link
Member

Add an ADR describing how to add product and version support to Konflux via a new controller

@ifireball ifireball requested a review from a team as a code owner February 4, 2024 08:04
@ifireball ifireball self-assigned this Feb 4, 2024
@ifireball ifireball force-pushed the pvc-adr branch 2 times, most recently from ce952bb to 864d0b8 Compare February 5, 2024 12:39
ADR/0033-product-version-controller.md Outdated Show resolved Hide resolved
ADR/0033-product-version-controller.md Outdated Show resolved Hide resolved
ADR/0033-product-version-controller.md Outdated Show resolved Hide resolved
ADR/0033-product-version-controller.md Outdated Show resolved Hide resolved
ADR/0033-product-version-controller.md Outdated Show resolved Hide resolved
ADR/0033-product-version-controller.md Outdated Show resolved Hide resolved
ADR/0033-product-version-controller.md Outdated Show resolved Hide resolved
ADR/0033-product-version-controller.md Outdated Show resolved Hide resolved
ADR/0033-product-version-controller.md Outdated Show resolved Hide resolved
ADR/0033-product-version-controller.md Outdated Show resolved Hide resolved
@ifireball ifireball requested a review from arewm February 8, 2024 12:12
Signed-off-by: Barak Korren <bkorren@redhat.com>
Signed-off-by: Barak Korren <bkorren@redhat.com>
Signed-off-by: Barak Korren <bkorren@redhat.com>
Signed-off-by: Barak Korren <bkorren@redhat.com>
Also renamed the file to better reflect the controller name.

Signed-off-by: Barak Korren <bkorren@redhat.com>
@ifireball ifireball requested review from twaugh and ralphbean April 1, 2024 09:55
@ifireball ifireball changed the title Add product version controller ADR feat(RHTAPWATCH-782): Add product version controller ADR Apr 1, 2024
@ifireball
Copy link
Member Author

@ralphbean what is the gap to getting this merged?

Signed-off-by: Barak Korren <bkorren@redhat.com>
@ralphbean ralphbean added the kind/feat Something new label Apr 30, 2024
@scoheb
Copy link
Contributor

scoheb commented May 9, 2024

LGTM!

@arewm arewm merged commit d1a89fa into konflux-ci:main May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feat Something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants