Add an experimental OpenSearch-based version #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also slightly changes the index structure to reduce the number of fields that need to be looked up in multi-match queries. The new version seems to perform slightly worse on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds experimental support for running Photon under the latest version of OpenSearch. It can be run in embedded mode thanks to opensearch-runner. External OpenSearch instances are supported as well but currently only via an unsecured HTTP connection.
The underlying Lucene library has changed quite a bit. Thus search results are not exactly the same but close enough in quality. Testing a planet installation against geocoder-tester I get comparable database sizes, execution time and number of good results.
The indexes are not expected to be binary compatible, so I made some small changes to how the collector indexes are organized. This should speed up the queries a little bit by avoiding multi-match queries. Other than that I've left the query structure as is. The newest version of OpenSearch has a few new interesting features but lets get this working as before first.
See README on how to build the new version. Please be aware that I have moved the final jars back to the
targetdirectory.Feedback welcome.