Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

140 protocol 20 support #141

Merged
merged 7 commits into from
Oct 30, 2023
Merged

140 protocol 20 support #141

merged 7 commits into from
Oct 30, 2023

Conversation

keliumJU
Copy link
Contributor

Description

In this PR was added the initial support for protocol 20.

Fixes #140

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@CristhianRodriguezMolina @keliumJU
Protocol 20 support
7b990a7 
Co-authored-by: norn <keliumJU@users.noreply.github.com>
@keliumJU
change camel-case
4e73511
@keliumJU keliumJU force-pushed the 140-protocol-20-support branch from 5e56c00 to 4e73511 Compare October 27, 2023 22:30
@keliumJU keliumJU requested a review from miguelnietoa October 27, 2023 22:31
miguelnietoa
miguelnietoa requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@miguelnietoa miguelnietoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keliumJU @CristhianRodriguezMolina comments added

@keliumJU keliumJU requested a review from miguelnietoa October 30, 2023 15:27
miguelnietoa
miguelnietoa approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@miguelnietoa miguelnietoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@keliumJU keliumJU merged commit 7a908c9 into v0.18 Oct 30, 2023
@keliumJU keliumJU deleted the 140-protocol-20-support branch October 30, 2023 16:30
@miguelnietoa miguelnietoa mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelnietoa miguelnietoa miguelnietoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keliumJU @miguelnietoa @CristhianRodriguezMolina