Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin requests-toolbelt>=1 to unbreak requests==2.30 #8

Merged
merged 4 commits into from
May 10, 2023

Conversation

gordonhart
Copy link
Member

@gordonhart gordonhart commented May 9, 2023

Recommended by the requests maintainers in psf/requests#6443. Left a TODO to remove — this pin seems like the right solution for us to apply in the short term, but longer term we really don't want to be pinning transient dependencies.

Opted to pin requests-toolbelt to the new major version instead of pinning transient urllib3. This appears to address the issue without requiring a transient dependency pin. It's not ideal to force users to pick up a very-new version of requests-toolbelt, but that is a very small package and the 1.0 release is quite innocuous.

pyproject.toml Outdated Show resolved Hide resolved
@gordonhart gordonhart changed the title Pin transient urllib3 dependency to unbreak requests==2.30 Pin newer requests-toolbelt to unbreak requests==2.30 May 9, 2023
@gordonhart gordonhart enabled auto-merge (squash) May 9, 2023 13:52
@gordonhart gordonhart changed the title Pin newer requests-toolbelt to unbreak requests==2.30 Pin requests-toolbelt>=1 to unbreak requests==2.30 May 9, 2023
@gordonhart gordonhart disabled auto-merge May 9, 2023 14:06
@gordonhart gordonhart enabled auto-merge (squash) May 9, 2023 14:07
@gordonhart gordonhart disabled auto-merge May 9, 2023 15:16
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #8 (0094a1f) into trunk (1590494) will increase coverage by 85.51%.
The diff coverage is n/a.

❗ Current head 0094a1f differs from pull request most recent head 4b821d7. Consider uploading reports for the commit 4b821d7 to get more accurate results

@@            Coverage Diff             @@
##           trunk       #8       +/-   ##
==========================================
+ Coverage       0   85.51%   +85.51%     
==========================================
  Files          0       93       +93     
  Lines          0     5863     +5863     
  Branches       0      640      +640     
==========================================
+ Hits           0     5014     +5014     
- Misses         0      767      +767     
- Partials       0       82       +82     

see 93 files with indirect coverage changes

@gordonhart gordonhart enabled auto-merge (squash) May 9, 2023 23:45
@gordonhart gordonhart merged commit 2b42046 into trunk May 10, 2023
@gordonhart gordonhart deleted the gh/pin-urllib3 branch May 10, 2023 00:36
@gordonhart
Copy link
Member Author

I'm getting different issues on different environments with this strict requests-toolbelt>=1 pin. Going to update to add an upper bound requests<2.30 instead, giving the ecosystem some time to adapt to this breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants