Include error messages returned by ffprobe or ffmpeg in non-zero status exception #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokorin
requested changes
Jun 3, 2022
src/main/java/com/github/kokorin/jaffree/process/BaseStdReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/kokorin/jaffree/process/BaseStdReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/kokorin/jaffree/ffprobe/FFprobeResultReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/kokorin/jaffree/process/GobblingStdReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/kokorin/jaffree/process/LoggingStdReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/kokorin/jaffree/process/ProcessHandler.java
Outdated
Show resolved
Hide resolved
|
Failed tests are probably related to #273 |
Thanks for the fast review - much appreciated! |
OK, no problem! |
|
I've now addressed your initial review comments, @kokorin |
kokorin
reviewed
Jun 3, 2022
src/main/java/com/github/kokorin/jaffree/process/BaseStdReader.java
Outdated
Show resolved
Hide resolved
|
@jonfryd Please add |
Done |
|
Let me know if you need additional changes to this, @kokorin |
kokorin
reviewed
Jun 3, 2022
src/main/java/com/github/kokorin/jaffree/process/ProcessNonZeroExitException.java
Outdated
Show resolved
Hide resolved
|
Thanks for reviewing this, @kokorin 👍 Have a nice weekend! |
kokorin
pushed a commit
that referenced
this pull request
Feb 8, 2023
…us exception (#306) * Include any error messages returned by ffprobe or ffmpeg in exception message * Return empty lists * Record errors in switch/case instead * Record messages in chronological order instead * Include process errors in a new exception * Don't use wilcard import * Added missing fail import * Include QUIET, as well * Don't use underscore style * #273 Ignore failing tests in ffmpeg/ffprobe 5.0 * Renaming to JaffreeAbnormalExitException (cherry picked from commit bdd741c)
kokorin
pushed a commit
that referenced
this pull request
Feb 8, 2023
…us exception (#306) * Include any error messages returned by ffprobe or ffmpeg in exception message * Return empty lists * Record errors in switch/case instead * Record messages in chronological order instead * Include process errors in a new exception * Don't use wilcard import * Added missing fail import * Include QUIET, as well * Don't use underscore style * #273 Ignore failing tests in ffmpeg/ffprobe 5.0 * Renaming to JaffreeAbnormalExitException (cherry picked from commit bdd741c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So basically this does what you suggested to me yesterday, I think.