Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the input parameter generic of FilterChain#addFilters #259

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

Hccake
Copy link
Contributor

@Hccake Hccake commented Dec 29, 2021

List<GenericFilter> list = new ArrayList<>();
list.add(...);
// A cast is required here
new FilterChain().addFilters((List) list);

Using generic caps is a good way to handle this situation

…tends Filter> to add a List<GenericFilter> collection
@kokorin
Copy link
Owner

kokorin commented Dec 29, 2021

Despite GenericFilter is the only Filter implementation in Jaffree, list of filters should have type List<Filter>.
But there is rational basis in this PR. Could you add to this PR similar changes for FilterGraph?

@Hccake
Copy link
Contributor Author

Hccake commented Dec 29, 2021

Despite GenericFilter is the only Filter implementation in Jaffree, list of filters should have type List<Filter>. But there is rational basis in this PR. Could you add to this PR similar changes for FilterGraph?

Ok, committed

@kokorin kokorin merged commit c621bde into kokorin:develop Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants