-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate OffsetView constructors taking index_list_type #4810
Deprecate OffsetView constructors taking index_list_type #4810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine beside the adding Kokkos::Experimental::range_type
Do you prefer to use |
As long we are not injecting an alias in the namespace. |
I prefer to have a constructor that allows me to do
and I don't see a need to introduce another templated one taking other tuple-like containers yet. |
95d49ce
to
05353a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment about the design choices above the constructor.
Retest this please. |
While looking at #4805, I found a
OffsetView
constructor takingindex_list_type
,i.e.,std::initializer_list
, objects as argument to denote begin and end for every dimension. This pull request deprecates that behavior to usestd::pair
instead so that specifying too many arguments is not possible.