Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExtendedReferenceWrapper for SYCL parallel_reduce #3802

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Remove ExtendedReferenceWrapper for SYCL parallel_reduce #3802

merged 2 commits into from
Feb 25, 2021

Conversation

masterleinad
Copy link
Contributor

It turns out that we actually don't need ExtendedReferenceWrapper if we are a bit more careful with the point when we set up the functor we actually want to run.
Using std::reference_wrapper instead also allows us to simplify make_sycl_function_wrapper and we can remove some code in Kokkos_FunctorAdapter.hpp, too.

@masterleinad masterleinad requested a review from nliber February 16, 2021 17:01
nliber
nliber approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@nliber nliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm always a fan of removing and simplifying code.

@dalg24
Copy link
Member

dalg24 commented Feb 16, 2021

All the defaultdevicetype.reduce_instantiation* tests are failing

@masterleinad
Copy link
Contributor Author

All the defaultdevicetype.reduce_instantiation* tests are failing

Yes, I'm hunting it down.

@masterleinad
Copy link
Contributor Author

Seems to work now.

@masterleinad masterleinad mentioned this pull request Feb 18, 2021
Merged
@dalg24 dalg24 merged commit ea4a44e into kokkos:develop Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nliber nliber nliber approved these changes

@dalg24 dalg24 dalg24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masterleinad @dalg24 @nliber