Added metadata callback to tools interface #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you please give a motivating example for being able to declare meta data? |
|
Many tools provide an ability to filter a pile of profiles based on some metadata fields (TAU, Caliper, I'd be astonished if Jonathan doesn't have something in Timemory). "Only show me the profiles that come from runs built with GCC." This gives our users a way to express such metadata without needing to link those tools in their application |
Conflicts: core/src/impl/Kokkos_Profiling.hpp core/unit_test/CMakeLists.txt
|
Retest this please |
masterleinad
approved these changes
Jan 12, 2021
jrmadsen
approved these changes
Jan 12, 2021
| @@ -85,6 +85,7 @@ int main(int argc, char** argv) { | |||
| Kokkos::Profiling::stopSection(sectionId); | |||
| Kokkos::Profiling::destroyProfileSection(sectionId); | |||
| Kokkos::Profiling::markEvent("profiling_event"); | |||
| Kokkos::Tools::declareMetadata("dogs", "good"); | |||
There was a problem hiding this comment.
This is incorrect. It should be:
Kokkos::Tools::declareMetadata("dogs", "very-good");
There was a problem hiding this comment.
TRUE. THE GOODNESS OF DOGS SHALL NOT BE UNDEREMPHASIZED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple metadata callback, but functional nonetheless. Allows users to declare metadata with a key,value call