Do not install libprinter-tool when testing is enabled #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer we do both the name change+versioning and the non-install, the
name I gave that was pretty terrible anyway
…On Wed, Aug 26, 2020 at 10:56 AM Daniel Arndt ***@***.***> wrote:
This is an alternative to #3308
<#3308>.
------------------------------
You can view, comment on, or merge this pull request online at:
#3313
Commit Summary
- Don't install printer-tool
File Changes
- *M* core/unit_test/CMakeLists.txt
<https://github.com/kokkos/kokkos/pull/3313/files#diff-dafd774bd4213a58df4e9768b90e719d>
(8)
Patch Links:
- https://github.com/kokkos/kokkos/pull/3313.patch
- https://github.com/kokkos/kokkos/pull/3313.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3313>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAGLSNBTW6YGG6WOOECBKDSCU5CFANCNFSM4QMBMVBQ>
.
--
Thanks,
David
|
I'd say why not for the prefix but the versioning is really overkill IMO |
|
No strong preference there, I don't mind extra safety mechanisms, but
certainly won't insist on them
…On Wed, Aug 26, 2020 at 11:10 AM Damien L-G ***@***.***> wrote:
I'd prefer we do both the name change+versioning and the non-install, the
name I gave that was pretty terrible anyway
… <#m_-7373817109408671065_>
I'd say why not for the prefix but the versioning is really overkill IMO
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3313 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAGLSIQALDEPTKTDIKNZNTSCU6ZHANCNFSM4QMBMVBQ>
.
--
Thanks,
David
|
|
Retest this please. |
DavidPoliakoff
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #3308.