Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor batched serial pbtrs implementation details and tests #2504

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yasahi-hpc
Copy link
Contributor

This PR aims at improving the implementation and testing of serial pbtrs.

  • Implementation details are inside Impl namespace.
  • Remove using namespace KokkosBatched from the test code
  • Rename variables starting from underscores in the test code
  • Remove the dependency to pbtrf from the pbtrs analytical tests (see the discussions in fix: getrs serial internal implementations #2488)
  • Move test specializations from Test_Batched_SerialPbtrs_Real.hpp and Test_Batched_SerialPbtrs_Complex.hpp into Test_Batched_SerialPbtrs.hpp.
  • Add docstring and assertion for Arg template parameters

Signed-off-by: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant