Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor serial pbtrf implementation details and tests #2503

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

yasahi-hpc
Copy link
Contributor

This PR aims at improving the implementation and testing of serial tbsv.

  • Moving implementation details into Impl namespace.
  • Integrate real and complex implementations with lacgv and syr.
  • Remove using namespace KokkosBatched from the test code
  • Rename variables starting from underscores in the test code
  • Simplify the ConjTrans in unit-test by using newly added ConjTrans operator in gemm
  • Move test specializations from Test_Batched_SerialPbtrf_Real.hpp and Test_Batched_SerialPbtrf_Complex.hpp into Test_Batched_SerialPbtrf.hpp.
  • Add docstring and assertion for Arg template parameters

Signed-off-by: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay looks good to me

@lucbv lucbv added the AT2-CI-APPROVAL Approve CI to run at SNL label Feb 19, 2025
@lucbv lucbv merged commit e56863a into kokkos:develop Feb 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT2-CI-APPROVAL Approve CI to run at SNL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants