Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iluk deprecate experimental #2495

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented Feb 6, 2025

No description provided.

lucbv added 2 commits February 5, 2025 17:37
Will make other commits to remove the usage through out the library.

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
After moving the functions out of experimental we need to update
tests so we do not call it ourselves anymore.

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
@lucbv lucbv self-assigned this Feb 6, 2025
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
@lucbv lucbv added the Cleanup Code maintenance that isn't a bugfix or new feature label Feb 6, 2025
@lucbv lucbv requested review from jgfouca and vqd8a February 6, 2025 16:10
@vqd8a
Copy link
Contributor

vqd8a commented Feb 6, 2025

@lucbv Just to make sure, the spiluk_numeric_streams interface is still in Experimental, isn't it?

@lucbv
Copy link
Contributor Author

lucbv commented Feb 6, 2025

Correct, I think it is still a bit early for that. Let me know if you want to take it out of experimental?

@vqd8a
Copy link
Contributor

vqd8a commented Feb 6, 2025

Correct, I think it is still a bit early for that. Let me know if you want to take it out of experimental?

@lucbv I am okay with letting it in experimental for a little while. Just wanted to make sure.

@lucbv lucbv merged commit bdc57ac into kokkos:develop Feb 6, 2025
18 checks passed
@lucbv lucbv deleted the iluk_deprecate_experimental branch February 6, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code maintenance that isn't a bugfix or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants