Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor serial tbsv implementation details and tests #2478

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

yasahi-hpc
Copy link
Contributor

@yasahi-hpc yasahi-hpc commented Jan 13, 2025

This PR aims at improving the implementation and testing of serial tbsv.

  • Moving implementation details into Impl namespace.
  • Use OpID and OpConj for conj operations instead of do_conj variable
  • Use Kokkos::is_view_v<AViewType> instead of Kokkos::is_view<AViewType>::value
  • Covering all the unit-tests for all the combinations of Non-Trans/Trans/ConjTrans
  • Remove using namespace KokkosBatched from the test code
  • Rename variables starting from underscores in the test code

Added based on the discussions in #2497

  • Add docstring and assertion for Arg template parameters

@lucbv
Copy link
Contributor

lucbv commented Feb 19, 2025

I don't think the gesvd error is related to this so we could merge the PR, fine with you @yasahi-hpc ?

Yuuichi Asahi added 5 commits February 19, 2025 16:00
Signed-off-by: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
Signed-off-by: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
Signed-off-by: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
Signed-off-by: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
Signed-off-by: Yuuichi Asahi <y.asahi@nr.titech.ac.jp>
@yasahi-hpc yasahi-hpc force-pushed the refactor-batched-serial-tbsv branch from cb93fa6 to 23c59fc Compare February 19, 2025 07:42
@yasahi-hpc
Copy link
Contributor Author

I don't think the gesvd error is related to this so we could merge the PR, fine with you @yasahi-hpc ?

I agree gesvd error should be unrelated. Based on the discussions in #2497, I added docstrings and assertion about Arg parameters. If it is good for you, I think this PR is ready to be merged.

If we find errors in gesvd, I will open an issue and fix that.

@lucbv lucbv self-requested a review February 19, 2025 14:45
@lucbv lucbv merged commit 9b4703d into kokkos:develop Feb 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT2-CI-APPROVAL Approve CI to run at SNL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants