Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish cmake TPL changes for Trilinos+MKL+SYCL #2298

Closed

Conversation

brian-kelley
Copy link
Contributor

This changes our BLAS/LAPACK cmake logic: if MKL is enabled, then its libraries provide the BLAS and LAPACK functions. We don't have to search for BLAS/LAPACK again in this case.

Follow on to #2185. Matches the KokkosKernels changes in trilinos/Trilinos#13330

@brian-kelley brian-kelley requested a review from lucbv August 6, 2024 23:19
@brian-kelley brian-kelley self-assigned this Aug 6, 2024
@brian-kelley brian-kelley changed the title Finish porting cmake TPL changes from Trilinos Finish cmake TPL changes for Trilinos+MKL+SYCL Aug 6, 2024
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_VEGA90A_ROCM561 to start: Total Wait = 3603

@brian-kelley brian-kelley marked this pull request as draft August 8, 2024 22:24
@brian-kelley
Copy link
Contributor Author

Converted to draft, it might not make sense to add MKL_PROVIDES_BLAS_LAPACK as a cmake variable here if trilinos/Trilinos#13330 ends up focusing only on the changes required for MKL+SYCL to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants