Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/osx.yml: test against most recent kokkos tag #2186

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

ndellingwood
Copy link
Contributor

  • test against most recent kokkos release rather than develop branch, as done with AT CI, to avoid compatibility breakages

- test against most recent kokkos release rather than develop branch, as
  done with AT CI, to avoid compatibility breakages
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, should be good just need to keep it up to date when we have releases : )

@ndellingwood
Copy link
Contributor Author

I marked as WIP to avoid the AT - this change only impacts the github-osx GA jobs

@lucbv
Copy link
Contributor

lucbv commented Apr 24, 2024

Okay, let's wait for these github runners to pick it up and we can merge afterwards

@ndellingwood ndellingwood merged commit c099cea into kokkos:develop Apr 25, 2024
7 checks passed
@ndellingwood
Copy link
Contributor Author

GA osx-ci checks all passed, merging

@ndellingwood ndellingwood deleted the osx-ci-master branch April 25, 2024 01:35
ndellingwood added a commit that referenced this pull request May 1, 2024
workflows/osx.yml: test against most recent kokkos tag

(cherry picked from commit c099cea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants