Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArmPL TPL support for KokkosBlas and KokkosBatched #874

Open
5 of 15 tasks
e10harvey opened this issue Jan 12, 2021 · 3 comments
Open
5 of 15 tasks

ArmPL TPL support for KokkosBlas and KokkosBatched #874

e10harvey opened this issue Jan 12, 2021 · 3 comments

Comments

@e10harvey
Copy link
Contributor

e10harvey commented Jan 12, 2021

@vqd8a
Copy link
Contributor

vqd8a commented Feb 3, 2021

@e10harvey Thanks for adding the CMake for ARMPL. I would like to add two comments:

  1. For ARMPL's BLAS, could you please also enable KOKKOSKERNELS_ENABLE_TPL_BLAS in the KokkosKernels_config.h when KOKKOSKERNELS_ENABLE_TPL_ARMPL is defined, so that we can use the current BLAS TPL support in Kokkos Kernels?
  2. It looks to me that single-threaded ARMPL (libarmpl.so) can be found
 =======================
KokkosKernels ETI Types
   Devices:  <OpenMP,HostSpace>
   Scalars:  double
   Ordinals: int
   Offsets:  int;size_t
   Layouts:  LayoutLeft

KokkosKernels TPLs
   ARMPL:       /opt/arm/armpl-20.3.0_A64FX_RHEL-8_gcc_aarch64-linux/lib/libamath.so;/opt/arm/armpl-20.3.0_A64FX_RHEL-8_gcc_aarch64-linux/lib/libarmpl.so
=======================

Can we also find multi-threaded ARMPL (libarmpl_mp.so) when OpenMP is enabled?

@e10harvey
Copy link
Contributor Author

1. For ARMPL's BLAS, could you please also enable `KOKKOSKERNELS_ENABLE_TPL_BLAS` in the `KokkosKernels_config.h` when `KOKKOSKERNELS_ENABLE_TPL_ARMPL` is defined, so that we can use the current BLAS TPL support in Kokkos Kernels?

Yes.

Can we also find multi-threaded ARMPL (libarmpl_mp.so) when OpenMP is enabled?

Yes.

I will flag you in the PR for this.

@vqd8a
Copy link
Contributor

vqd8a commented Feb 3, 2021

@e10harvey Thanks, Evan.

e10harvey added a commit to e10harvey/kokkos-kernels that referenced this issue Jun 2, 2021
  - Add armpl invocation to the 'experimental' test type.
  - Related to kokkos#874.
e10harvey added a commit to e10harvey/kokkos-kernels that referenced this issue Jun 2, 2021
  - Add armpl invocation to the 'experimental' test type.
  - Related to kokkos#874.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants