Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SIMD flags to support aarch64 #44

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

KeisukeShima
Copy link
Contributor

Related tier4#8, we changed to not use the architecture-specific SIMD flags in order to support both x64 and aarch64 CPUs.
To accomplish this, we used the -march=native option. According to our internal evaluation, this will specify the best option for each CPU architecture.

@koide3
Copy link
Owner

koide3 commented Jan 22, 2022

I agree that -march=native would be beneficial in many cases. Meanwhile, it sometimes causes segfaults when we build the package with PCL installed via apt. To keep the package usable with the standard prebuilt PCL, I would like to make the march=native flag optional. Could you please update the code so the flag is enabled only when a cmake option is enabled (e.g., -DBUILD_WITH_MARCH_NATIVE=ON)?

Signed-off-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
@KeisukeShima
Copy link
Contributor Author

Thanks for your comment. I added a flags to switch the build flags. 57c119c
cc: @harihitode

@KeisukeShima KeisukeShima force-pushed the feature/support-aarch64 branch from 57c119c to 4ae2196 Compare January 25, 2022 10:54
@koide3 koide3 merged commit 1e4684b into koide3:master Jan 27, 2022
@kenji-miyake kenji-miyake deleted the feature/support-aarch64 branch January 27, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants