Add missing fields for testing #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SetEpisodePartNumber() to EPG, add SetYear() to Recordings and EPG.
11 tasks
emveepee
added a commit
to emveepee/pvr.demo
that referenced
this pull request
Jul 28, 2024
A few available tags where not implemented for testing. Update program and test file. Port of kodi-pvr#155.
emveepee
added a commit
to emveepee/pvr.demo
that referenced
this pull request
Aug 20, 2024
A few available tags where not implemented for testing. Update program and test file. Port of kodi-pvr#155.
|
@emveepee closing because this cannot go into Omega. |
Thanks on PR 159 I noted this should be canceled I wasn't sure how. BTW there is nothing wrong with the PR in Omega, just no way to display it. |
|
Why should we merge code of no value into the omega addon? This makes absolutely no sense. |
Agreed which is why asked for it to taken out but it is not an absolute no. Not all tests have to be against a skin, initially I used it to check that the database was being updated correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To assist testing without a backend, add SetYear() to Recordings and EPG and add SetEpisodePartNumber() to EPG.
Note currently EpisodePartNumber is not exposed for skinnning.