Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Can we have working base stats ? #88

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Can we have working base stats ? #88

merged 6 commits into from
Sep 28, 2022

Conversation

vikiival
Copy link
Member

  • πŸ‘½ πŸ› added missing values to series
  • πŸ¦‘ Codegen
  • ⚑ updated cache to have emoteCount
  • 🧼 eslint for series.model
  • πŸ—ƒοΈ new series

Thank you for your contribution to the KodaDot Indexer.
πŸ‘‡ _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • This PR is required for kodadot/nft-gallery#<issue_number>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

@vikiival vikiival linked an issue Sep 28, 2022 that may be closed by this pull request
@vikiival vikiival requested a review from roiLeo September 28, 2022 14:07
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need emotes column if there won't be data in? (manually asign 0 value)

reduce the limit to 100 would be better?

@vikiival
Copy link
Member Author

Why do you need emotes column if there won't be data in? (manually asign 0 value)

Otherwise it would fail on frontend (check issue #87 )

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it would fail on frontend (check issue #87)

Aight, weird flex but ok!

@vikiival vikiival merged commit 46b36de into main Sep 28, 2022
@vikiival vikiival deleted the some-fake-emotes branch September 28, 2022 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series insight fail
2 participants