Release 004 #131
Release 004 #131
Conversation
| @@ -288,9 +288,11 @@ export async function handleOfferPlace(context: Context): Promise<void> { | |||
| // logger.debug(`offer: ${JSON.stringify({ ...event, price: String(event.amount), expiresAt: String(event.expiresAt) }, null, 2)}`) | |||
| const id = createTokenId(event.collectionId, event.sn); | |||
| const entity = ensure<NE>(await get(context.store, NE, id)); | |||
| plsBe(real, entity); | |||
|
|
|||
| // entity doesn't need to exist | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Good catch!
But It can fail on unknown foreign key in DB 🤔
There was a problem hiding this comment.
Good catch!
But It can fail on unknown foreign key in DB 🤔
which foreign key? it only concerns Offers, if you find a particular case I would like to see it
I think we have no choice here you can check #127 to know why I've made this particular change
There was a problem hiding this comment.
from Offers to NFTs
But if you try that and it does not fail I am happy to try that in rococo
| if (event.isV55) { | ||
| const { who: caller, class: classId, instance: instanceId } = event.asV55; | ||
| return { collectionId: classId.toString(), sn: instanceId.toString(), caller: addressOf(caller) }; | ||
| return { collectionId: classId.toString(), sn: instanceId.toString(), caller: addressOf(caller), maker: addressOf(ctx.event.call?.args.maker) }; |
There was a problem hiding this comment.
any idea how to fix this line? or have something a bit cleaner
|
Also @roiLeo I think this update should go to main imo |
well depend how you want to handle release, I'm more into testing it on Rococo then release it on 005. By the way, I wanted to ask you if it was possible to have a certain right on the 004 branch since it's testnet |
Sure! |
|
LETS GO! |
TS error:
Unsafe member access .maker on an `any` valueneed little help to edit
MarketplaceOfferWithdrawnEventeventPR type
What's new?
Before submitting Pull Request, please make sure:
Optional
Screenshot