Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: replace .container.is-fluid (again) #9535

Closed
wants to merge 4 commits into from

Conversation

pbkompasz
Copy link
Contributor

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

@pbkompasz pbkompasz requested a review from a team as a code owner February 23, 2024 11:56
@pbkompasz pbkompasz requested review from yangwao and removed request for a team February 23, 2024 11:56
@kodabot
Copy link
Collaborator

kodabot commented Feb 23, 2024

WARNING @pbkompasz PR for issue #9245 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9245

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 505da9e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65d887d44898b9000884ac26
😎 Deploy Preview https://deploy-preview-9535--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Feb 23, 2024

Code Climate has analyzed commit 505da9e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@exezbcz exezbcz requested review from preschian and daiagi and removed request for yangwao February 29, 2024 12:42
@preschian preschian requested a review from prury February 29, 2024 14:14
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm (not tested)

@exezbcz
Copy link
Member

exezbcz commented Mar 5, 2024

could you check @prury ?

@prury
Copy link
Member

prury commented Mar 5, 2024

@exezbcz 20 seconds later:
navbar stretched:
image

overall:

first.glance.mp4

will not proceed and test it all over since PR was clearly not tested by author

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 5, 2024
@prury
Copy link
Member

prury commented Mar 11, 2024

closing since no proper testing/response

@prury prury closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: container size to tailwind
5 participants