Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: replaced .container.is-fluid #9279

Closed
wants to merge 13 commits into from
Closed

style: replaced .container.is-fluid #9279

wants to merge 13 commits into from

Conversation

pbkompasz
Copy link
Contributor

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

@pbkompasz pbkompasz requested a review from a team as a code owner February 4, 2024 17:15
@pbkompasz pbkompasz requested review from preschian and roiLeo and removed request for a team February 4, 2024 17:15
@kodabot
Copy link
Collaborator

kodabot commented Feb 4, 2024

SUCCESS @pbkompasz PR for issue #9245 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c04557d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65d72854e68394000790f228
😎 Deploy Preview https://deploy-preview-9279--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roiLeo roiLeo mentioned this pull request Feb 4, 2024
Closed
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Feb 4, 2024
@roiLeo roiLeo mentioned this pull request Feb 5, 2024
Merged
7 tasks
@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Feb 5, 2024
roiLeo
roiLeo suggested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roiLeo
roiLeo reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the remaining

Capture d’écran 2024-02-07 à 8 40 19 AM

roiLeo
roiLeo reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check navbar

Screenshot 2024-02-07 at 09-55-08 KodaDot - NFT Market Explorer

@prury
Copy link
Member

prury commented Feb 9, 2024

build/tests not running

@roiLeo
Copy link
Contributor

roiLeo commented Feb 9, 2024

build/tests not running

double check

@prury
Copy link
Member

prury commented Feb 9, 2024

@pbkompasz
Copy link
Contributor Author

@prury Fixed those, for most of them the issue was px-5 was not applying padding: 1.25rem but some other value.

@pbkompasz pbkompasz force-pushed the refactor-container-fluid branch from 1a1b5ad to c04557d Compare February 22, 2024 10:56
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 22, 2024

Code Climate has analyzed commit c04557d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member

prury commented Feb 22, 2024

image

@pbkompasz pbkompasz closed this Feb 23, 2024
@pbkompasz pbkompasz deleted the refactor-container-fluid branch February 23, 2024 09:41
@pbkompasz pbkompasz restored the refactor-container-fluid branch February 23, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newraina newraina newraina left review comments

@preschian preschian preschian approved these changes

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: container size to tailwind
6 participants
@pbkompasz @kodabot @prury @roiLeo @preschian @newraina