Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Phases in drop page #9044

Closed
wants to merge 59 commits into from
Closed

feat: Phases in drop page #9044

wants to merge 59 commits into from

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 18, 2024 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-01-23 at 17 23 55@2x

hassnian and others added 28 commits January 16, 2024 17:24
@hassnian
add: new holder of drop iteration
607e2db
@hassnian
ref: move simple minimum-funds
cf925a3
@hassnian
ref: holder of collection requirements
6a273c2
@hassnian
add: holder of collection tooltip
49b343f
@hassnian
add: check if holder of collection nfts are already claimed
4d746f5
@hassnian
remove: empy tags
792d0b2
@hassnian
add: check has minimumFunds amount
5f99825
@hassnian
add: requiremnt check available for mint amount
1a257fc
@hassnian
Merge branch 'main' into issue-8886
a7f99de
@hassnian
add: missing hasAmount minimumFundsProps
14a49f4
@hassnian
add: mobile version holder of requirements
a942544
@hassnian
fix: checkAlreadyClaimedNfts wrong collection
cc92d98
@hassnian
ref: use correct transaltion
848884a
@hassnian
ref: transaltion key rename
20350eb
@hassnian
add: check hasMinimumFunds mint button disabled and label
7df5f90
@hassnian
ref: move holder of collection logic
502800b
@hassnian
Merge branch 'main' into issue-8886
7decf03
@hassnian
fix: on wallet disconnect update available nft count
5c58d26
@hassnian
Merge branch 'issue-8886' of https://github.com/hassnian/nft-gallery …
439141a 
…into issue-8886
@hassnian
ref: remove boolean
37101e0
@hassnian
fix: disabled button if does not have available nfts
225234e
@hassnian
ref: rename checkAvailableNfts
441529a
@hassnian
Merge branch 'main' into issue-8886
690dbab
@hassnian
ref: icon name and class
bffc3a2
@hassnian
Merge branch 'issue-8886' of https://github.com/hassnian/nft-gallery …
7ee4b5f 
…into issue-8886
@hassnian
Merge branch 'main' into issue-8886
e587ff7
@hassnian
add: basic phases drop
d46cf0f
@hassnian
add: mint phase state
d73c5b3
@netlify Netlify
Copy link

netlify bot commented Jan 18, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6d2b6c5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65afafcda7b600000750cb3c
😎 Deploy Preview https://deploy-preview-9044--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 18, 2024

SUCCESS @hassnian PR for issue #9016 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@hassnian hassnian marked this pull request as ready for review January 23, 2024 04:31
@hassnian hassnian requested a review from a team as a code owner January 23, 2024 04:31
@hassnian hassnian requested review from preschian and roiLeo and removed request for a team January 23, 2024 04:31
@hassnian hassnian marked this pull request as draft January 23, 2024 04:31
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 23, 2024

Code Climate has analyzed commit 6d2b6c5 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 5

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

8 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian
Copy link
Contributor Author

hassnian commented Jan 30, 2024 •
edited
Loading

already a lot of conflicts and v2 drop page is coming , also multi phases worker issue is not ready

will reopen as new cleaner pr once we have the worker issue done.

@hassnian hassnian closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

@roiLeo roiLeo Awaiting requested review from roiLeo roiLeo is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
large Pull request is large waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phases in drop page
2 participants
@hassnian @kodabot