Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deduplicate drop information - Total available items #8442

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Dec 6, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image image

Copilot Summary

🤖[deprecated] Generated by Copilot at 4f5e1fe

Removed the display of the total available items and the total count of the drop from various drop components, such as Generative.vue, UnlockableContainer.vue, DropContainer.vue, and voteDrop/DropContainer.vue. This simplifies the UI and avoids confusion for the users. Also removed the unused translation key mint.unlockable.totalAvailableItem from en.json.

🤖[deprecated] Generated by Copilot at 4f5e1fe

Oh we're the coders of the drop feature
And we like to keep our UI neat
We don't need no total count or items
We just DropContainer.vue and repeat

@Jarsen136 Jarsen136 requested a review from a team as a code owner December 6, 2023 12:33
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team December 6, 2023 12:33
@kodabot
Copy link
Collaborator

kodabot commented Dec 6, 2023

SUCCESS @Jarsen136 PR for issue #8441 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4f5e1fe
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65706a10bab8a300087bbe07
😎 Deploy Preview https://deploy-preview-8442--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Dec 6, 2023

Code Climate has analyzed commit 4f5e1fe and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 6, 2023
@yangwao
Copy link
Member

yangwao commented Dec 6, 2023

good

image

@yangwao
Copy link
Member

yangwao commented Dec 6, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit 2e2ef75 into kodadot:main Dec 6, 2023
@yangwao
Copy link
Member

yangwao commented Dec 6, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5.99 USD/DOT ~ 3.339 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x8dce99f64f58e1f4410f0595d93b3342410b99dd7cb054b26916a33b9e08654f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 6, 2023
@prury prury mentioned this pull request Dec 7, 2023
4 tasks
This was referenced Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deduplicate drop information - Total available items
3 participants