Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ minimark package #8413

Merged
merged 1 commit into from
Dec 5, 2023
Merged

⬆️ minimark package #8413

merged 1 commit into from
Dec 5, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 5, 2023

@roiLeo roiLeo requested a review from a team as a code owner December 5, 2023 08:18
@roiLeo roiLeo requested review from daiagi and Jarsen136 and removed request for a team December 5, 2023 08:18
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3f2f9b2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656edcea5c37b6000877d93d
😎 Deploy Preview https://deploy-preview-8413--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Dec 5, 2023

AI-Generated Summary: This pull request primarily introduces three changes. In the transactionBurn.ts file, it modifies the argument passed to the executeTransaction function to use the createNewInteraction function. This represents a new mechanism of interaction, specifically with the DESTROY action and collectionId as the parameters.

The second change is an update to the @kodadot1/minimark package version in both the package.json and pnpm-lock.yaml files. It's updated from ^0.1.10 to ^0.1.13.

Lastly, in the pnpm-lock.yaml file, the lockfileVersion is downgraded from 6.1 to 6.0 and version updates are made to dependencies like '@polkadot/util' and '@polkadot/keyring'.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 5, 2023
@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Dec 5, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 5, 2023

Code Climate has analyzed commit 3f2f9b2 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo mentioned this pull request Dec 5, 2023
Closed
@roiLeo roiLeo requested a review from preschian December 5, 2023 08:19
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@vikiival vikiival merged commit 7e01215 into kodadot:main Dec 5, 2023
@roiLeo roiLeo deleted the fix/rmrk/destroy branch December 5, 2023 09:42
This was referenced Dec 7, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

@preschian preschian Awaiting requested review from preschian

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roiLeo @vikiival