Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated NeoInput to tailwindcss #8355

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 1, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 06b8d3d

Refactored the styling of the NeoInput and NeoField components to use Tailwind CSS instead of custom SCSS. This reduces the complexity and dependency of the input component styling and makes it easier to apply a consistent theme across the UI.

🤖[deprecated] Generated by Copilot at 06b8d3d

Sing, O Muse, of the skillful coder who refashioned
The styles of the input fields with Tailwind CSS,
Removing the tangled web of SCSS imports and mixins,
And making them shine like the stars of the night sky.

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 1, 2023 22:21
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 1, 2023 22:21
Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e7a97e3
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656ede2b053180000890213e
😎 Deploy Preview https://deploy-preview-8355--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Dec 1, 2023

WARNING @shashkovdanil PR for issue #8352 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8352

Copy link
Contributor

reviewpad bot commented Dec 1, 2023

AI-Generated Summary: This pull request involves changes in two CSS files related to NeoInput and NeoField components. The major modification in this patch is the migration from the previous scss syntax to the tailwindcss utility classes with the use of @apply directive. This transformation has led to the deletion of a number of lines that previously used ktheme(). Now, they are replaced with more straightforward Tailwind CSS classes, which results in shorter, cleaner code and higher readability.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 1, 2023
@prury prury requested review from preschian and Jarsen136 and removed request for yangwao December 4, 2023 13:45
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 4, 2023
@roiLeo roiLeo dismissed Jarsen136’s stale review December 5, 2023 08:24

push it push it

@roiLeo roiLeo added this pull request to the merge queue Dec 5, 2023
Merged via the queue into kodadot:main with commit 143f6b0 Dec 5, 2023
Copy link

codeclimate bot commented Dec 5, 2023

Code Climate has analyzed commit e7a97e3 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration NeoInput to tailwindcss
6 participants