Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated NeoIcon to tailwindcss #8351

Merged
merged 7 commits into from
Dec 6, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Dec 1, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖[deprecated] Generated by Copilot at 3245680

Refactored NeoIcon component with Tailwind CSS and added animation utility for spinning icons. This enhances the UI library with more consistent and reusable styles.

🤖[deprecated] Generated by Copilot at 3245680

We spin the icons of doom
With Tailwind we control their speed
We cast away the dark theme
And refactor with CSS creed

@shashkovdanil shashkovdanil requested a review from a team as a code owner December 1, 2023 20:06
@shashkovdanil shashkovdanil requested review from yangwao and removed request for a team December 1, 2023 20:06
@kodabot
Copy link
Collaborator

kodabot commented Dec 1, 2023

WARNING @shashkovdanil PR for issue #8349 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8349

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ece5fb9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/657023e1d94d390008cf8bb6
😎 Deploy Preview https://deploy-preview-8351--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Dec 1, 2023

AI-Generated Summary: This pull request carries out the migration of the NeoIcon component from previous SCSS styling to the tailwindcss framework. This is reflected in changes in two files: NeoIcon.scss and tailwind.config.js. In NeoIcon.scss, theme imports are removed, replaced by the application of relevant tailwindcss classes. The old Stylus-based style definitions (color and animation definitions) are replaced by equivalent tailwindcss utility classes. On the other hand, in tailwind.config.js, a new animation utility is added that replicates the spin animation previously defined in pure CSS. Overall, this supports the project's transition towards a more unified, tailwind-driven styling approach.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 1, 2023
@prury prury requested review from preschian and removed request for yangwao December 4, 2023 11:49
@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels Dec 4, 2023
@roiLeo roiLeo enabled auto-merge December 5, 2023 08:23
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Dec 6, 2023

Code Climate has analyzed commit ece5fb9 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added this pull request to the merge queue Dec 6, 2023
Merged via the queue into kodadot:main with commit 6d7eb1c Dec 6, 2023
This was referenced Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration NeoIcon to tailwindcss
5 participants