Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clicking on item in atomic swap should open new tab #11329

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: clicking on item in atomic swap should open new tab #11329

merged 1 commit into from
Jan 2, 2025

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Click nft would open new tab on these pages

  1. select others swap items
  2. select my swap items
  3. review swap

@Jarsen136 Jarsen136 requested a review from a team as a code owner January 1, 2025 15:02
@Jarsen136 Jarsen136 requested review from preschian and hassnian and removed request for a team January 1, 2025 15:02
@netlify Netlify
Copy link

netlify bot commented Jan 1, 2025 •
edited
Loading

✅ Deploy Preview for polkadot ready!

Name Link
🔨 Latest commit 6d668b4
🔍 Latest deploy log https://app.netlify.com/sites/polkadot/deploys/677558ec715802000830f096
😎 Deploy Preview https://deploy-preview-11329--polkadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 16
Accessibility: 83
Best Practices: 83
SEO: 81
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@netlify Netlify
Copy link

netlify bot commented Jan 1, 2025 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6d668b4
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/677558ecdd9f3b00089881ce
😎 Deploy Preview https://deploy-preview-11329--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@exezbcz
Copy link
Member

exezbcz commented Jan 1, 2025

cant really test as nothing loads for me on the preview

@Jarsen136
Copy link
Contributor Author

cant really test as nothing loads for me on the preview

Could you try with this preview link? https://deploy-preview-11329--koda-canary.netlify.app/

@exezbcz
Copy link
Member

exezbcz commented Jan 1, 2025

works

@hassnian hassnian added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jan 2, 2025
@vikiival vikiival enabled auto-merge January 2, 2025 11:13
@vikiival vikiival added this pull request to the merge queue Jan 2, 2025
Merged via the queue into kodadot:main with commit d7a2210 Jan 2, 2025
26 checks passed
This was referenced Jan 3, 2025
Merged
Merged
This was referenced Jan 26, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@hassnian hassnian hassnian approved these changes

Assignees
No one assigned
Labels
S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clicking on item in atomic swap should open new tab
5 participants
@Jarsen136 @exezbcz @preschian @hassnian @vikiival